update filenames #60
Merged
update filenames #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass! |
yashpatel6
reviewed
Mar 22, 2024
There was a problem hiding this comment.
Couple of record-keeping things: CHANGELOG should be updated and the output section in the README should be updated to match the standardized filenames
@nwiltsie for the config test, I'm not sure if it's expected but the comments in files changed are still appearing even after the test passes?
…eline-calculate-targeted-coverage into nzeltser-update-filenames
Done! (I think) Was there anything else that needed to be changed in the README? I just made minor tweaks, all the unique file identifiers are still pretty much the same as before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #36
Standardize output filenames.
Testing Results
My nftests are currently failing because the .sha512 checksum files include the name of the file, which of course doesn't match the test cases. However the checksum hashes themselves are identical. It's a bit odd that nftest compares checksum files by making checksums of the checksums. I can update the test cases but is there a better way to do this? Does nftest support checksum comparison when the test case itself is a checksum?
Also, do I need to update the test case filenames to match the new filenames? If so, I shall await feedback on correctness of current filenames before updating.
Checklist
I have read the code review guidelines and the code review best practice on GitHub check-list.
I have reviewed the Nextflow pipeline standards.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
I have added my name to the contributors listings in the
manifestblock in thenextflow.configas part of this pull request, am listedalready, or do not wish to be listed. (This acknowledgement is optional.)
I have added the changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.I have updated the version number in the
metadata.yamlandmanifestblock of thenextflow.configfile following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)I have tested the pipeline on at least one A-mini sample.